From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 16 Jun 2009 06:18:37 GMT
Subject: Re: [PATCHv3 3/4] submodule, repack: migrate to git-sh-setup's say()
Message-ID: <7v3aa0g0qq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7viqiwg1rl.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> ...
> If the convention is "GIT_QUIET, when set to non-empty string, squelches
> the output", then I think the callers should be more consistent and the
> call to prune-packed should say something like this, which is admittedly a
> roundabout way:
>
> 	git prune-packed ${GIT_QUIET:+-q}
>
> for consistency (and then what you set to GIT_QUIET in the first hunk I
> quoted does not matter anymore---it can even be t or 1 or whatever).
>
> I think this does not matter too much, because I suspect that in the
> longer term scripted Porcelains are going away, but still...

What I meant was that my _style_ comment does not matter too much.  The
addition of "quiet" _is_ a worthwhile thing to do, I think.