From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 13 Jan 2010 06:57:03 GMT
Subject: Re: [PATCH 3/3] commit: show interesting ident information in summary
Message-ID: <7v3a2asda8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100112154631.GC24957@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> +	if (strbuf_cmp(&author_ident, &committer_ident)) {
> +		strbuf_addstr(&format, "\n Author: ");
> +		strbuf_percentquote_buf(&format, &author_ident);
> +	}
> +	if (!user_ident_explicitly_given) {
> +		strbuf_addstr(&format, "\n Committer: ");
> +		strbuf_percentquote_buf(&format, &committer_ident);
> +	}

This is much better.

We might want an advice message inside the latter case, helping the user
learn how to spell his name correctly.  This is designed to trigger for
people/repositories that are not configured, and by definition the
majority of that target audience are new people.

The extra message will disappear once committer information is explicitly
given, there is no need to protect the advice message with the usual
"advice.*" configuration.

Thanks.