From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 11 Sep 2010 19:13:39 GMT
Subject: Re: [PATCH] builtin/describe.c: ignore untracked changes in submodules
Message-ID: <7v39tgf5zw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1529126586.2758911.1284228699341.JavaMail.fmail@mwmweb045>

Jens Lehmann <Jens.Lehmann@web.de> writes:

>>So if I didn't misunderstand something here I would rather vote against this change,
>>git describe should append a '-dirty' when git status would show modifications, no?
>
> And maybe we should teach "git describe" the "--ignore-submodules" option, then
> you could tell describe what to pass to the diff-index command. Thoughts?

It is sensible to add the option, and handle_ignore_submodules_arg() call
to grab "diff.ignoresubmodules" configuration) to the command, perhaps.

Both "status" and "diff" are described in the documentation as having
"all" as the default value for --ignore-submodules option, but by default
neither ignores changes in the submodules.  So it seems consistent for the
command to take submodule changes into account by default.