From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 30 Sep 2010 16:09:58 GMT
Subject: Re: [PATCHv4 15/15] Replace "unset VAR" with "unset VAR;" in testsuite as per t/README
Message-ID: <7v39srkyax.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTimgTAerCNcSHBR9t-s-ThWHLMXdsb2T=E2w8gpB@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

> They break the && cascades, but aren't the && cascades already
> inherently broken due to the unportable return value of unset?

Of course; that is the breakage you are trying to fix, no?  My comment was
that I understand you are trying to, but the patch is not actually fixing
it.

If anything, it is making it worse. Earlier we would have got a false
breakage that would make people notice and take a look. With your patch
applied, we instead would let a breakage in parts earlier than these
"unset VAR;" go unnoticed, no?