From: Junio C Hamano Date: Fri, 05 Nov 2010 22:38:26 GMT Subject: Re: [PATCH v3] Porcelain scripts: Rewrite cryptic "needs update" error message Message-ID: <7v39rfs8f1.fsf@alter.siamese.dyndns.org> In-Reply-To: <20101027145548.GA1136@kytes> Ramkumar Ramachandra writes: > Ramkumar Ramachandra writes: >> Although Git interally has the facility to differentiate between >> porcelain and plubmbing commands and appropriately print errors, >> several shell scripts invoke plubming commands triggering cryptic >> plumbing errors to be displayed on a porcelain interface. This patch >> replaces the "needs update" message in git-pull and git-rebase, when >> `git update-index` is run, with a more friendly message. >> >> Reported-by: Joshua Jensen >> Reported-by: Thore Husfeldt >> Signed-off-by: Ramkumar Ramachandra >> --- >> Ref: <1285877017-8060-1-git-send-email-artagnon@gmail.com> for v2. >> Ref: <1285514516-5112-1-git-send-email-artagnon@gmail.com> for v1. >> >> Thanks to Matthieu for reviewing v1 and Junio for reviewing v2: I've >> tried to attack the problem more conservatively in this patch. It >> doesn't list paths, and doesn't print "generic" advice. > > Junio: Is this patch alright? I did not see anything glaringly wrong in the patch offhand. The new messages look a bit too verbose, though. Will queue and see what people would say.