From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 23 Oct 2011 20:16:44 GMT
Subject: Re: [PATCH 00/22] Refactor to accept NUL in commit messages
Message-ID: <7v39ej5uqb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20111023160744.GA22444@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> But as Duy mentions, we have an encoding header. Shouldn't we treat it
> like binary goo until we do reencode_log_message, and _then_ we can
> break it into lines?

That's sensible. If we go that route, I think the "one allocation of
separate struct commit_buffer pointed from a pointer field in struct
commit to replace the current member 'buffer'" is a reasonable thing
to do.