From: Junio C Hamano Date: Sun, 12 Feb 2012 17:07:48 GMT Subject: Re: [PATCH] strbuf: move strbuf_readline_fd() from bundle.c to strbuf.{c,h} Message-ID: <7v39agkmjf.fsf@alter.siamese.dyndns.org> In-Reply-To: 徐迪 writes: > Shouldn't I supposed to receive any information about this patch? Not necessarily X-<. Things can get lost in the noise, and sending a reminder message like you just did, after waiting for a few to several days, is considered a good practice. > Has it accepted or not? Anything and everything being considered for inclusion is reachable from the tip of the 'next' branch; other patches that might turn out to be of value, or ones that at least deserve more sets of eyeballs, are only in the 'pu' branch. > If not what wrong with this patch? That is not a valid question to ask. We do not apply a patch merely because it is _not wrong_. It must be clear why it is a good thing for the project to apply the patch. Your patch in question is barely a day old and I didn't have a chance to look at it, and I do not think other volunteer reviewers did, either, so I don't know if it is wrong or it has merit yet.