From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 11 May 2012 03:57:59 GMT
Subject: Re: [PATCH 4/4] notes: only append a blob to a blob
Message-ID: <7v3977mks8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120510154519.GB23941@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I think the behavior is correct, but the message confused me. If I see
> "cannot append a foo to a bar", it implies to me that it is the
> combination of the elements that is the limiting factor. But it is not.
> It is that one (or more) of the elements is not a blob, regardless of
> what the other element is. So I think this would be more accurate:
>
>   if (type != OBJ_BLOB)
>           die(_("cannot append to a non-blob note"));
>   if (msg->type != OBJ_BLOB)
>           die(_("cannot append a non-blob object to a note"));

It certainly looks easier to grok.