From: Junio C Hamano Date: Tue, 31 Jul 2012 21:05:18 GMT Subject: Re: [PATCH/RFC] grep: add a perlRegexp configuration option Message-ID: <7v3947iqup.fsf@alter.siamese.dyndns.org> In-Reply-To: J Smith writes: > On Tue, Jul 31, 2012 at 4:30 PM, Junio C Hamano wrote: >> J Smith writes: >> >>> ... For the sake of completeness (verbosity? pedantry?) I also >>> included a setting for "extended" which is equivalent to true. >> >> Good thinking. >> >>> With this sort of change, would a more generic "grep.regexpMode", >>> "grep.patternType" or something similar perhaps be more descriptive, >>> with "grep.extendedRegexp" being aliased for backwards compatibility >>> purposes? I could also add that functionality if desired. >> >> A variable called "extendedRegexp" already reads quite naturally if >> it can have value to say what kind of extendedness is desired, at >> least to me. So I do not care too deeply either way. > > On the flip side, it might be useful to some to have the option to set > the value to "fixed" for the "--fixed-strings" argument, in which case > the option becomes less a type of extended regexp and more of a simple > search string. Were that to be the case, I think "grep.patternType" > would feel the most precise. > > I think for completeness at the very least I should work in the > "fixed" value as an valid value, option naming aside. Ok, then grep.patternType it is. Thanks.