From: Junio C Hamano Date: Mon, 10 Sep 2012 21:18:52 GMT Subject: Re: [PATCH v3 09/14] filter_refs(): build refs list as we go Message-ID: <7v392pmv9f.fsf@alter.siamese.dyndns.org> In-Reply-To: <1347171589-13327-10-git-send-email-mhagger@alum.mit.edu> Michael Haggerty writes: > Instead of temporarily storing matched refs to temporary array > "return_refs", simply append them to newlist as we go. This changes > the order of references in newlist to strictly sorted if "--all" and > "--depth" and named references are all specified, but that usage is > broken anyway (see the last two tests in t5500). Removes two warts (the temporary array in general, and the fastarray[] special case) with one patch. Nicely done.