From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 08 Oct 2012 21:19:32 GMT
Subject: Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability
Message-ID: <7v391ok6fv.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAP30j147c47y=cWVQNCtOdjp4mqV0kjhrSr7ZEfwDCyfQWthcw@mail.gmail.com>

Ben Walton <bdwalton@gmail.com> writes:

> On Mon, Oct 8, 2012 at 6:45 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>>> Thanks, but is "-p" essential for this test to pass, or can we get
>>>> away with just "-R"?
>>>
>>> Besides, when you spot a potential problem, please ask "git grep"
>>> to catch them all.
>>
>> In other words, how about doing this instead?
>
> This works.  I was responding to a failing test so I didn't look for
> other instances.  Clearly I should have...I must not be exercising
> those other tests.
>
> Acked-By: Ben Walton <bdwalton@gmail.com>

I actually was planning to pass the blame to you so I'll re-queue it
under your "Author:" name, with S-o-b.

Thanks.