From: Junio C Hamano Date: Thu, 29 Nov 2012 16:13:12 GMT Subject: Re: [PATCH] t4049: avoid test failures on filemode challenged file systems (Windows) Message-ID: <7v38zss7zb.fsf@alter.siamese.dyndns.org> In-Reply-To: <50B71B33.1090000@viscovery.net> Johannes Sixt writes: >> It turns out that there are at least two bugs in the diffstat >> counting code. This series comes on top of the earlier 74faaa1 (Fix >> "git diff --stat" for interesting - but empty - file changes, >> 2012-10-17) to fix them. > > The tests still fail on Windows. I am not sure whether there is a > difference in comparing the file system against the index or a commit. > If there is, then the updated tests might not test the same thing. The hunks in the patch look fine. The last one that tests unmerged entries do not have to have "chmod" if it gives you trouble (you would need to reduce number of files from 4 to 3 if you go that route, I think).