From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 28 Apr 2013 19:31:11 GMT
Subject: Re: [PATCH 6/6] sparse: Fix mingw_main() argument number/type errors
Message-ID: <7v38uaqwow.fsf@alter.siamese.dyndns.org>
In-Reply-To: <517C6DEF.2050305@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> Why not take the opposite direction with a patch like this?
> ...
> diff --git a/compat/mingw.h b/compat/mingw.h
> index 389ae01..74e7b87 100644
> --- a/compat/mingw.h
> +++ b/compat/mingw.h
> @@ -452,11 +452,11 @@ int xwcstoutf(char *utf, const wchar_t *wcs, size_t utflen);
>  
>  void mingw_startup();
>  #define main(c,v) dummy_decl_mingw_main(); \
> -static int mingw_main(); \
> +static int mingw_main(int, const char **); \
>  int main(int argc, const char **argv) \

But traditionally main is declared like 

	int main(int argc, char *argv[]);

without const, no?