From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 07 May 2013 14:38:29 GMT
Subject: Re: [PATCH v2 1/3] fast-{import,export}: use get_sha1_hex() directly
Message-ID: <7v38tyn9cq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1367793534-8401-2-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> It's wrong to call get_sha1() if they should be SHA-1s, plus
> inefficient.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---

It appears that "they should be SHA-1s" assumption does not hold;
this patch breaks at least 3303, 9020, and 9300.

Also assuming these are always 40-hex goes directly against what is
documented in Documentation/git-fast-import.txt (look for "Here
committish is any of the following").  My bad while reviewing the
earlier round.

I've redone 'pu' (which was failing the test last night) after
dropping this and keeping only patches 2 and 3 from the series.