From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 21 Jul 2013 22:09:44 GMT
Subject: Re: [PATCH] Revert "compat/unsetenv.c: Fix a sparse warning"
Message-ID: <7v38r7sgyf.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1374436448-8199-1-git-send-email-tsunanet@gmail.com>

Benoit Sigoure <tsunanet@gmail.com> writes:

> This reverts commit ec535cc27e6c4f5e0b1d157e04f5511f166ecd9d.
>
> POSIX explicitly states "the [environ] variable, which
> must be declared by the user if it is to be used directly".
> Not declaring it causes compilation to fail on OS X.
>
> Instead don't declare the variable on MinGW, as it causes
> a spurious warning there.
>
> Signed-off-by: Benoit Sigoure <tsunanet@gmail.com>

Thanks, will queue.

> ---
>
> Resending as I forgot to Sign-off the previous patch.
>
>  compat/unsetenv.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/compat/unsetenv.c b/compat/unsetenv.c
> index 4ea1856..bf5fd70 100644
> --- a/compat/unsetenv.c
> +++ b/compat/unsetenv.c
> @@ -2,6 +2,9 @@
>  
>  void gitunsetenv (const char *name)
>  {
> +#if !defined(__MINGW32__)
> +     extern char **environ;
> +#endif
>       int src, dst;
>       size_t nmln;