From: Junio C Hamano Date: Thu, 29 Jun 2006 21:54:54 GMT Subject: Re: [RFC] Cache negative delta pairs Message-ID: <7v1wt7pqz5.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Linus Torvalds writes: > Instead of having a separate cache, wouldn't it be much better to just > take the hint from the previous pack-file? > > In the repacking window, if both objects we are looking at already came > from the same (old) pack-file, don't bother delta'ing them against each > other. > > That means that we'll still always check for better deltas for (and > against!) _unpacked_ objects, but assuming incremental repacks, you'll > avoid the delta creation 99% of the time. I bow down before you. No ugly special-case caching, just automatically "the right thing", with very little overhead. It just makes sense. We have a winner. ;-)