From: Junio C Hamano <junkio@cox.net>
Date: Wed, 27 Sep 2006 06:48:42 GMT
Subject: Re: [PATCH] gitweb: tree view: hash_base and hash are now context sensitive
Message-ID: <7v1wpxhkj9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060926211720.21355.qmail@web31808.mail.mud.yahoo.com>

Luben Tuikov <ltuikov@yahoo.com> writes:

> --- Jakub Narebski <jnareb@gmail.com> wrote:
>> I think that this need some thinking over. For blob we have two
>> "base" objects: tree which have specified blob, and commit which
>> have tree which have specified blob. We might want to specify
>> that all hash*base are to the commit-ish.
>
> Agreed, we should always refer to the commit-ish, for obvious
> reasons.
>
> This patch doesn't make this decision though.  It simply
> sets hash_base to HEAD if not defined.
>
> Now, since "git-ls-tree" works on both commit-ish and
> tree-ish, we are ok.

I think so, too.  Jakub?