From: Junio C Hamano <junkio@cox.net>
Date: Wed, 10 Jan 2007 01:10:04 GMT
Subject: Re: [PATCH] Don't die in git-http-fetch when fetching packs.
Message-ID: <7v1wm3hekz.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070110010452.GA30610@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

> My sp/mmap changes to pack-check.c modified the function such that
> it expects packed_git.pack_size to be populated with the total
> bytecount of the packfile by the caller.
>
> But that isn't the case for packs obtained by git-http-fetch as
> pack_size was not initialized before being accessed.  This caused
> verify_pack to think it had 2^32-21 bytes available when the
> downloaded pack perhaps was only 305 bytes in length.  The use_pack
> function then later dies with "offset beyond end of packfile"
> when computing the overall file checksum.
>
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---
>
>  For the tip of my sp/mmap topic.  Without it HTTP fetch and push
>  support is severely broken as it cannot deal with packs.

Ah, thanks.  I've seen this today and a repeated fetch after
that fixed it and thought it was a mirroring lag.