From: Junio C Hamano <junkio@cox.net>
Date: Tue, 16 Jan 2007 02:46:46 GMT
Subject: Re: [PATCH] Replace "echo -n" with printf in shell scripts.
Message-ID: <7v1wlv1yeh.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <17437.1168911089@lotus.CS.Berkeley.EDU>

Jason Riedy <ejr@EECS.Berkeley.EDU> writes:

> Not all echos know -n.  This was causing a test failure in
> t5401-update-hooks.sh, but not t3800-mktag.sh for some reason.

We have done this already so it might be too late to raise this
question, but does everybody have printf?

> diff --git a/contrib/remotes2config.sh b/contrib/remotes2config.sh
> index 25901e2..b996996 100644
> --- a/contrib/remotes2config.sh
> +++ b/contrib/remotes2config.sh
> @@ -11,7 +11,7 @@ if [ -d "$GIT_DIR"/remotes ]; then
>  	{
>  		cd "$GIT_DIR"/remotes
>  		ls | while read f; do
> -			name=$(echo -n "$f" | tr -c "A-Za-z0-9" ".")
> +			name=$(printf "$f" | tr -c "A-Za-z0-9" ".")

This should almost be safe as no sane person would have a remote
whose name is 'foo%s'...