From: Junio C Hamano Date: Wed, 21 Mar 2007 16:17:21 GMT Subject: Re: [PATCH] Added make options NO_GUI and WITH_P4IMPORT. Message-ID: <7v1wji371q.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20070321160126.GH14837@codelabs.ru> Eygene Ryabinkin writes: > Technically, the checks in Makefile will look as 'ifndef NO_GUI && NO_TCL_TK' > instead of 'ifndef NO_GUI'. Later they can diverge as the software will > evolve. > > Are people happy with such plan? Maybe later you might even want to view the graphical history from the server displaying on remote X, who knows? We have NO_CURL and such because lack of the necessary libraries and headers prevent your build from completing, but in the case of git-gui and gitk, they are just scripts and you would not have any trouble in building. I do not know if adding more conditional to Makefile in order to skip them is worth it.