From: Junio C Hamano Date: Fri, 06 Apr 2007 20:35:52 GMT Subject: Re: [PATCH] rename_ref(): only print a warning when config-file update fails Message-ID: <7v1wixkzpz.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <11758483861506-git-send-email-hjemli@gmail.com> Lars Hjemli writes: > If git_config_rename_section() fails, rename_ref() used to return 1, which > left HEAD pointing to an absent refs/heads file (since the actual renaming > had already occurred). I wonder if rolling back the rename that was asked is an option. We would want to keep these low-level things atomic whenever possible.