From: Junio C Hamano Date: Fri, 18 Jan 2008 10:08:24 GMT Subject: Re: [PATCH] git-send-email.perl: check for lines longer than 998 characters Message-ID: <7v1w8fh2ef.fsf@gitster.siamese.dyndns.org> In-Reply-To: <47907914.6000105@viscovery.net> Johannes Sixt writes: > You are right here. My thought was that even though the recipient gets a > broken patch, he would be able to fix it up. This may be acceptable for > peer-to-peer communication, but not for a development style that involves > many recipients. > > Then git-format-patch and log-family with --pretty=email -p could warn > about these candidates-to-be-broken patches. I'd rather not, unless it is explicitly asked for by a separate command line option. Transferring over SMTP is not the only (nor even primary) use of format-patch output. On the other hand, git-send-email _is_ all about SMTP transfer. Perhaps a loop over input files upfront to check the line length limit, and warn if there are suspiciously long lines even before sending the first piece of e-mail out, would be a reasonable approach.