From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 23 Feb 2008 20:50:28 GMT
Subject: Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh
Message-ID: <7v1w732y97.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080223204005.GA12502@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Sat, Feb 23, 2008 at 09:13:39PM +0100, Johannes Sixt wrote:
>
>> > -cat > fake-editor.sh <<\EOF
>> > -#!/bin/sh
>> > +echo "#!$SHELL" >fake-editor
>> 
>> Did you mean fake-editor.sh here?
>
> Gah, yes. Not sure how I was even able to run the test with that error.

Simple.  fake-editor.sh does not begin with #! anymore and exec
causes /bin/sh to run, and your system happens to have a sane
shell there.  If you used $SHELL not $SHELL_PATH and wrote to
fake-editor.sh, you would have noticed that using $SHELL there
was wrong as it would have said "#!bash" for you ;-)