From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 12 Sep 2008 21:59:12 GMT
Subject: Re: [PATCH 2/6] git rm: Support for removing submodules
Message-ID: <7v1vzpnhzj.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7v8wtxniez.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

>> +{
>> +	char *key = submodule_by_path(name);
>> +	char *sectend = strrchr(key, '.');
>> +
>> +	assert(sectend);
>> +	*sectend = 0;
>
> Here is one caller I questioned in my comments on [1/6]...

Another thing --- can submodule_by_path() ever return NULL saying "I do
not see one in the configuration"?