From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 24 Jul 2009 23:39:28 GMT
Subject: Re: [PATCH 2/2] After renaming a section, print any trailing variable definitions
Message-ID: <7v1vo5647j.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090725071105.6117@nanako3.lavabit.com>

Nanako Shiraishi <nanako3@lavabit.com> writes:

> Quoting Alex Vandiver <alex@chmrr.net>
>
>> diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh
>> index 43ea283..8c43dcd 100755
>> --- a/t/t1300-repo-config.sh
>> +++ b/t/t1300-repo-config.sh
>> @@ -460,6 +460,28 @@ EOF
>>  test_expect_success "rename succeeded" "test_cmp expect .git/config"
>>  
>>  cat >> .git/config << EOF
>> +[branch "vier"] z = 1
>> +EOF
>
> Isn't this a syntax error?
>
> Documentation/config.txt says this.

Even if it were, I think it would be nice to allow it.  I'll have to
re-read Alex's patch, but I thought it was sane.  Perhaps we can update
the documentation, mildly hinting that it is allowed without encouraging
it too strongly, as I think it is a good style to have these on separate
lines.

Dscho?  Have any suggestions/comments on the patch?