From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 09 Aug 2009 18:22:00 GMT
Subject: Re: [PATCH 5/6 (v2)] full integration of rev-cache into git's revision walker, completed test suite
Message-ID: <7v1vnk97av.fsf@alter.siamese.dyndns.org>
In-Reply-To: <op.uyb1vl2jtdk399@sirnot.private>

"Nick Edelen" <sirnot@gmail.com> writes:

> This patch provides a working integration of rev-cache into the revision 
> walker, along with some touch-ups:

This message from me is not about the patch 5/6 at all.  It is about your
earlier patches in the series.

> ...
> -	printf("queue:\n");
> +	fprintf(stderr, "queue:\n");
> ...
> -	printf("work:\n");
> +	fprintf(stderr, "work:\n");
> ...
> -	printf("pending:\n");
> +	fprintf(stderr, "pending:\n");
> ...
> - 	pptr = &item->parents;
> +	pptr = &item->parents;
> ...
> -#define SLOP		5
> +#define SLOP			5
> ...

These are all "Shoot, the mistakes in earlier ones need to be fixed here"
changes.

Please fix them in the patch earlier in the series so that you do not have
to make, and more importantly, reviewers do not have to get distracted by,
these fix-up in a later patch like this.