From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 18 Aug 2009 16:50:12 GMT
Subject: Re: [PATCH] block-sha1: Windows declares ntohl() in winsock2.h
Message-ID: <7v1vn9f4mz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.2.00.0908181240400.6044@xanadu.home>

Nicolas Pitre <nico@cam.org> writes:

> On Tue, 18 Aug 2009, Nicolas Pitre wrote:
>
>> Well...  Given that git already uses ntohl/htonl quite extensively in 
>> its core already, I'd suggest making this more globally available 
>> instead.
>
> What about something like this?

For git's own use, I would be much happier with this change.

But given that there are some people wanting to snarf block-sha1/*.[ch]
out to use them standalone, I have a slight hesitation against introducing
the dependency to git-compat-util.h, making it unclear to them that all
this file wants from outside are ntohl, htonl and memcpy.