From: Junio C Hamano Date: Mon, 24 Aug 2009 18:19:46 GMT Subject: Re: [PATCH] send-email: confirm on empty mail subjects Message-ID: <7v1vn1gjlp.fsf@alter.siamese.dyndns.org> In-Reply-To: Jan Engelhardt writes: > On Thursday 2009-08-06 08:25, Junio C Hamano wrote: > >>Jan Engelhardt writes: >> >>> When the user forgot to enter a subject in a compose session, >>> send-email will now inquire whether this is really intended, similar >>> to what the Alpine MUA does when a subject is absent. >> >>This seems to break t9001... >> > > Did I miss something in building? > > 19:26 sovereign:../git/git-1.6.4.1 > quilt pu > Applying patch patches/send-email-empty-subject.diff > patching file git-send-email.perl Is this using 'pu' with your patch? Near the tip of the 'pu' branch I have a iffy workaround to "unbreak" the issue, but it is a rather sledgehammer approach I do not feel comfortable enough to squash into your patch yet.