From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 23 Oct 2009 20:05:55 GMT
Subject: Re: ks/precompute-completion
Message-ID: <7v1vktc1uk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <fabb9a1e0910231216j2a024ac5mf5b5ccb5322722f8@mail.gmail.com>

Sverre Rabbelier <srabbelier@gmail.com> writes:

> This is my main concern, adding 'bash_completion' as a target to all:
> would be ok; why would 'make clean' break it? As long as you don't add
> "make -C contrib/completion clean' to the main clean target there's no
> problem?

"make clean" should remove it, because it is a normal build product,
if you make your "make all" build completion scripts.

The word _should_ is used in the RFC2119 sense: there may exist valid
reasons in particular circumstances to ignore a particular item, but the
full implications must be understood and carefully weighed before choosing
a different course.