From: Junio C Hamano Date: Fri, 09 Jul 2010 00:57:50 GMT Subject: Re: [PATCH] diff.c: fix a graph output bug Message-ID: <7v1vbdo4j5.fsf@alter.siamese.dyndns.org> In-Reply-To: <7vhbk9o6ie.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > struggleyb.nku@gmail.com writes: > >> From: Bo Yang >> >> Ouput the line_prefix ahead of color sequence. > > Justification for the patch, and/or a better bug description ("when run > with this combination of options, X gets painted in that color that is not > meant to be used for X") please? >> >> Signed-off-by: Bo Yang Perhaps something like this? From: Bo Yang Date: Thu, 8 Jul 2010 23:12:34 +0800 Subject: [PATCH] diff.c: fix a graph output bug When --graph is in effect, the line-prefix typically has colored graph line segments and ends with reset. The color sequence "set" given to this function is for showing the metainfo part of the patch text and (1) it should not be applied to the graph lines, and (2) it will be reset at the end of line_prefix so it won't be effect anyway. Signed-off-by: Bo Yang Signed-off-by: Junio C Hamano --- diff.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) ...