From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 18 Jan 2011 15:04:21 GMT
Subject: Re: [PATCH] Documentation/fast-import: put explanation of M 040000 <dataref> "" in context
Message-ID: <7v1v4amex6.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110116022234.GA28452@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

> Omit needless words ("Additionally ... <path> may also" is redundant).
> While at it, place the explanation of this special case after the
> general rules for paths to provide the reader with some context.
>
> diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
> index f56dfca..e2a46a5 100644
> --- a/Documentation/git-fast-import.txt
> +++ b/Documentation/git-fast-import.txt
> @@ -545,6 +542,9 @@ The value of `<path>` must be in canonical form. That is it must not:
>  * contain the special component `.` or `..` (e.g. `foo/./bar` and
>    `foo/../bar` are invalid).
>  
> +In `040000` mode, `<path>` can be the empty string (`""`)
> +to specify the root of the tree.
> +

Thanks, but is "In x mode" an appropriate wording here in the first place?
I would expect x to be some action (e.g. In navigation mode, typing many
keys just beep, and in edit mode, typing most keys just insert -- vi) but
the word "mode" doesn't fit that pattern (unless we take a bitpattern "x"
to mean "the act of creating a path with mode bits x").