From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 05 Aug 2011 17:01:03 GMT
Subject: Re: [PATCH] rebase -i: fix has_action
Message-ID: <7v1uwz4wts.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4E3BFB86.4010408@sohovfx.com>

Andrew Wong <andrew.w@sohovfx.com> writes:

> On 08/04/2011 03:34 PM, Junio C Hamano wrote:
>> How about removing the unnecessary negation from the logic and directly
>> ask what we really want to know?
>>
>> That is, "Do we have a line that is _not_ comment?"
>>
>> 	has_action () {
>>           sane_grep -v -e '^#' -e '^[   ]*$' "$1" >/dev/null
>> 	}
> How about also including comments that begins with spaces? i.e.

Not interested.

It would be _clear_ if you inserted extra space before '#'; Noe's issue is
that it is not clear if you have extra space on a blank line, which I am a
bit more sympathetic.