From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 23 Dec 2011 20:58:00 GMT
Subject: Re: [PATCH] Specify a precision for the length of a subject string
Message-ID: <7v1urvc8fb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20111223103511.GA10029@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Here's how I would have done it. Not involving %w at all, but applying
> equally to all placeholders.

Hmm, just curious why you rejected the %w() approach, as enhancing %w
sounded to me like a better approach at the design level, but that was a
knee-jerk reaction without inspecting the codepaths involved myself hence
not knowing the potential amount of work required.

>   - userformat_want_item should also respect the same magic (it already
>     duplicates some of the "-/+/ " magic. It might be nice to factor
>     that part out).

I recall this was a bit of a bear when I looked at the area last time.