From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 27 Jul 2012 21:31:43 GMT
Subject: Re: [PATCH 4/4] Move initialization of Git::SVN variables into Git::SVN.
Message-ID: <7v1ujw28n4.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50130062.7090901@pobox.com>

Michael G Schwern <schwern@pobox.com> writes:

> On 2012.7.27 1:07 PM, Eric Wong wrote:
>> While Makefile.PL now finds .pm files on its own, it does not
>> detect new files after it generates perl/perl.mak.
>
> Are you saying this doesn't work?
>
> perl Makefile.PL
> make -f perl.mak
> touch Git/Foo.pm
> perl Makefile.PL
> make -f perl.mak
>
> or this?
>
> perl Makefile.PL
> make -f perl.mak
> touch Git/Foo.pm
> make -f perl.mak

Neither of the above.  Nobody should be typing "perl Makefile.PL"
inside our source tree unless he is trying to debug our Makefiles
anyway.

What does not work is this sequence:

	make
        >perl/Git/Foo.pm
        make

Makefile at the top-level, which builds perl/perl.mak by running
"perl Makefile.PL" in perl/ subdirectory, doesn't have dependencies
[*1*], so in the above sequence, the second invocation of "make"
fails to rebuild perl/perl.mak, which causes Git/Foo.pm forgotten
from the build/installation step.

And that is what happened to Git/SVN.pm.


[Footnote]

*1* I also suspect perl/Makefile lacks this dependency even though
it has its own rule to build perl/perl.mak---don't they need to be
cleaned-up and merged???