From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 26 Jan 2013 21:43:23 GMT
Subject: Re: [PATCH] tests: turn on test-lint-shell-syntax by default
Message-ID: <7v1ud71uys.fsf@alter.siamese.dyndns.org>
In-Reply-To: <51037E5F.8090506@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

> Do we really need  "which" to detect if frotz is installed?

I think we all know the answer to that question is no, but why is
that a relevant question in the context of this discussion?  One of
us may be very confused.

I thought the topic of this discussion was that, already knowing
that "which" should never be used anywhere in our scripts, you are
trying to devise a mechanical way to catch newcomers' attempts to
use it in their changes, in order to prevent patches that add use of
"which" to be sent for review to waste our time.  I was illustrating
that the approach to override "which" in a shell function for test
scripts will not be a useful solution for that goal.