From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 17 Apr 2013 17:51:07 GMT
Subject: Re: git log - crash and core dump
Message-ID: <7v1ua9f3lg.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130417063942.GA27703@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> What about sane_ident_split in builtin/commit.c? It explicitly rejects a
> NULL date. The logic in determine_author_info is a little hard to follow
> (it assembles the ident line with fmt_ident and then reparses it), but I
> believe it should be catching a bogus line from "commit -c", or from
> GIT_AUTHOR_DATE in the environment.

Yeah, you are of course right. I noticed that "fmt_ident then parse"
sequence a bit funny, too. It seems to manually parse to prepare
what it feeds fmt_ident.

> As a side note, when determine_author_info sees a bogus ident, it
> appears to just silently ignore it, which is probably a bad thing.

True, too.