From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 23 Apr 2013 15:16:29 GMT
Subject: Re: [PATCHv2 4/7] t7008: demonstrate behavior of grep with textconv
Message-ID: <7v1ua1l1ki.fsf@alter.siamese.dyndns.org>
In-Reply-To: <5137a5a48ae6c70ad716d985a22d53ec311ee05a.1366718624.git.git@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

> Currently, "git grep" does not honor any textconv filters. Demonstrate
> this in the tests.
>
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> ---
>  t/t7008-grep-binary.sh | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/t/t7008-grep-binary.sh b/t/t7008-grep-binary.sh
> index 26f8319..126fe4c 100755
> --- a/t/t7008-grep-binary.sh
> +++ b/t/t7008-grep-binary.sh
> @@ -145,4 +145,27 @@ test_expect_success 'grep respects not-binary diff attribute' '
>  	test_cmp expect actual
>  '
>  
> +cat >nul_to_q_textconv <<'EOF'
> +#!/bin/sh
> +"$PERL_PATH" -pe 'y/\000/Q/' < "$1"
> +EOF
> +chmod +x nul_to_q_textconv
> +
> +test_expect_success 'setup textconv filters' '
> +	echo a diff=foo >.gitattributes &&
> +	git config diff.foo.textconv "\"$(pwd)\""/nul_to_q_textconv
> +'
> +
> +test_expect_failure 'grep does not honor textconv' '
> +	echo "a:binaryQfile" >expect &&
> +	git grep Qfile >actual &&

This should pass --textconv to "git grep".

> +	test_cmp expect actual
> +'
> +
> +test_expect_failure 'grep blob does not honor textconv' '
> +	echo "HEAD:a:binaryQfile" >expect &&
> +	git grep Qfile HEAD:a >actual &&

Likewise.

> +	test_cmp expect actual
> +'
> +
>  test_done