From: Junio C Hamano Date: Sun, 12 May 2013 22:19:49 GMT Subject: Re: [PATCH] patch-ids.c: cache patch IDs in a notes tree Message-ID: <7v1u9bvo1m.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130512085934.GG2299@serenity.lan> John Keeping writes: >> But it is not a big problem. Either 3-way merge notices that there >> is nothing new, or you get a conflict and have chance to inspect >> what is going on. > > It's not a problem here, but false negatives would be annoying if you're > looking at "git log --cherry-mark". The primary thing to notice is that it is not a new problem with or without the caching layer. As Linus mentioned how patch-ids are computed by ignoring offsets and whitespaces, the filtering is done as a crude approximation and false negatives are part of design, so making the cache more complex by recording hash of the binary and/or options used to compute misses the fundamental.