From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 20 Jul 2013 03:27:05 GMT
Subject: Re: [PATCH 3/7] connect.c: teach get_remote_heads to parse "shallow" lines
Message-ID: <7v1u6tud12.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1374065234-870-4-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> diff --git a/cache.h b/cache.h
> index dd0fb33..7665e03 100644
> --- a/cache.h
> +++ b/cache.h
> @@ -1091,6 +1091,7 @@ struct extra_have_objects {
>  };
>  extern struct ref **get_remote_heads(int in, char *src_buf, size_t src_len,
>  				     struct ref **list, unsigned int flags,
> +				     struct extra_have_objects *,
>  				     struct extra_have_objects *);

When it is the sole parameter of a specific type (i.e. not "char *",
int, size_t, etc. but an application specific structure like "struct
extra_have_objects *"), it is perfectly fine (and even preferrable)
to omit the parameter name from the declaration, as it is clear what
the parameter is and means.

But when you add another of the same type, you need to give both of
them a descriptive name (e.g. the ones you use in the definition).

Otherwise, somebody who wants to write a caller cannot tell which
"struct extra_have_objects *" parameter is the extra and which one
is the shallow graft points list.