From: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Date: Mon, 20 May 2024 20:55:26 GMT
Subject: Re: [GSoC][PATCH v2] t/: port helper/test-strcmp-offset.c to unit-tests/t-strcmp-offset.c
Message-ID: <7o3cyisx3suyqhe24xkfbraaxq4vzgy5er2tbshbtgfinkugjk@gmjtg7bhudwo>
In-Reply-To: <xmqqseycdxe9.fsf@gitster.g>

On Mon, 20 May 2024, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Please do not base a new topic on 'next', as I will NOT be applying
> > it on top of 'next'.
> > ...
> > Unless the conflicts are severe and is impractical, in which case
> > see Documentation/SubmittingPatches and look for "Under truly
> > exceptional circumstances".  But the conflict in Makefile about
> > UNIT_TEST_PROGRAMS in this case hadly qualifies as one.

Will make sure for the next time.

> > Anyway, thanks for a patch.
> 
> I've backported the patch to apply to "master" and queued it on its
> own topic, so that it no longer has to wait for all other topic in
> 'next'.  The Makefile looks like the attached, which is just with
> trivial difference in the context.  We only need to remove
> strcmp-offset from the TEST_BUILTIN_OBJS and instead add a
> corresponding one to UNIT_TEST_PROGRAMS, and that does not change no
> matter what other test-*.o are added to the former or t-* are added
> to the latter.
> 
> We may want to sort the UNIT_TEST_PROGRAMS list alphabetically at
> some point, by the way.

That was aleady done in 'la/hide-trailer-info' (next).

Thanks.