From: Ben Peart <peartben@gmail.com>
Date: Mon, 30 Oct 2017 12:38:56 GMT
Subject: Re: [PATCH v3] 0/4 fsmonitor fixes
Message-ID: <7fc39ba0-d1a3-7e96-8585-e82c54dc3e7c@gmail.com>
In-Reply-To: <20171027232637.30395-1-alexmv@dropbox.com>



On 10/27/2017 7:26 PM, Alex Vandiver wrote:
> Updates since v2:
> 
>   - Fix tab which crept into 1/4
> 
>   - Fixed the benchmarking code in the commit message in 2/4 to just
>     always load JSON::XS -- the previous version was the version where
>     I'd broken that to force loading of JSON::PP.
> 
>   - Remove the --no-pretty from the t/ version of query-watchman in
>     2/4; I don't know how I messed up diff'ing the file previously, but
>     if there are already differences, it makes sense to let them slide.
> 

Thanks Alex, nice improvements.  This looks good to go.