From: Geoffrey Irving <irving@naml.us>
Date: Sun, 08 Jun 2008 05:39:41 GMT
Subject: Re: [PATCH / RFC] cherry: cache commit to patch-id pairs to avoid repeating work
Message-ID: <7f9d599f0806072239je3a7ec0q258d7770c15fa962@mail.gmail.com>
In-Reply-To: <7f9d599f0806071636j1df57b6eqb5808f083dafd6a2@mail.gmail.com>

On Sat, Jun 7, 2008 at 4:36 PM, Geoffrey Irving <irving@naml.us> wrote:
> Added cached-sha-map.[hc] implementing a persistent hash map from sha1 to sha1.
> The map is read with mmap, and completely rewritten if any entries change.  It
> would be good to add incremental update to handle the usual case where only a
> few entries change.
>
> This structure is used by patch-ids.c to cache the mapping from commit to
> patch-id into $GIT_DIR/patch-id-cache.  In the one case I've tested so far,
> this speeds up the second invocation of git-cherry by two orders of magnitude.
>
> Original code cannibalized from Johannes Schindelin's notes-index structure.
>
> <snip>

Forgot to cc people from previous threads.

Is starting a new thread each time I update a patch the correct way to
do things?

Geoffrey