From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Tue, 28 Feb 2017 17:34:17 GMT
Subject: Re: [PATCH v5 24/24] t1406: new tests for submodule ref store
Message-ID: <7e5ef9e7-bd90-1917-d8eb-c6310c2744ab@alum.mit.edu>
In-Reply-To: <20170222140450.30886-25-pclouds@gmail.com>

On 02/22/2017 03:04 PM, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  t/t1406-submodule-ref-store.sh (new +x) | 95 +++++++++++++++++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100755 t/t1406-submodule-ref-store.sh
> 
> diff --git a/t/t1406-submodule-ref-store.sh b/t/t1406-submodule-ref-store.sh
> new file mode 100755
> index 000000000..3b30ba62f
> --- /dev/null
> +++ b/t/t1406-submodule-ref-store.sh
> [...]

I haven't actually read this far in the patch series, but I noticed that
a test in this file fails:


t1406-submodule-ref-store.sh                     (Wstat: 256 Tests: 15
Failed: 1)
  Failed test:  10
  Non-zero exit status: 1

I didn't have time to look into it more; let me know if you can't
reproduce it.

Michael