From: Derrick Stolee <stolee@gmail.com>
Date: Tue, 27 Apr 2021 18:13:09 GMT
Subject: Re: [PATCH 14/23] fsmonitor-fs-listen-macos: add macos header files for FSEvent
Message-ID: <7da80a62-7820-3fb8-a0e9-4356d9ea597e@gmail.com>
In-Reply-To: <67fa7c7b8ac79b05d0773dc0affbe39b77aa4893.1617291666.git.gitgitgadget@gmail.com>

On 4/1/2021 11:40 AM, Jeff Hostetler via GitGitGadget wrote:
> From: Jeff Hostetler <jeffhost@microsoft.com>
> 
> Include MacOS system declarations to allow us to use FSEvent and
> CoreFoundation APIs.  We need GCC and clang versions because of
> compiler and header file conflicts.
...
> This is a known problem and tracked in GCC's bug tracker:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93082
> 
> In the meantime, let's not block things and go the slightly ugly route
> of declaring/defining the FSEvents constants, data structures and
> functions that we need, so that we can avoid above-mentioned issue.
> 
> Let's do this _only_ for GCC, though, so that the CI/PR builds (which
> build both with clang and with GCC) can guarantee that we _are_ using
> the correct data types.

I appreciate that this issue with header files is isolated to its own
patch.

Thanks,
-Stolee