From: Bagas Sanjaya <bagasdotme@gmail.com>
Date: Tue, 02 Nov 2021 10:17:22 GMT
Subject: Re: [PATCH v2] i18n: fix typos found during l10n for git 2.34.0
Message-ID: <7d9a893e-5dad-bd21-4ef7-6d47303abdc1@gmail.com>
In-Reply-To: <20211101021417.9549-1-worldhello.net@gmail.com>

> diff --git a/builtin/index-pack.c b/builtin/index-pack.c
> index 15ae406e6b..c23d01de7d 100644
> --- a/builtin/index-pack.c
> +++ b/builtin/index-pack.c
> @@ -1486,7 +1486,7 @@ static void rename_tmp_packfile(const char **final_name,
>   		if (!*final_name)
>   			*final_name = odb_pack_name(name, hash, ext);
>   		if (finalize_object_file(curr_name, *final_name))
> -			die(_("unable to rename temporary '*.%s' file to '%s"),
> +			die(_("unable to rename temporary '*.%s' file to '%s'"),
>   			    ext, *final_name);
>   	} else if (make_read_only_if_same) {
>   		chmod(*final_name, 0444);
> diff --git a/gpg-interface.c b/gpg-interface.c
> index 800d8caa67..68d2f29be7 100644
> --- a/gpg-interface.c
> +++ b/gpg-interface.c
> @@ -775,7 +775,7 @@ static const char *get_default_ssh_signing_key(void)
>   		if (keys[0] && starts_with(keys[0]->buf, "ssh-")) {
>   			default_key = strbuf_detach(keys[0], NULL);
>   		} else {
> -			warning(_("gpg.ssh.defaultKeycommand succeeded but returned no keys: %s %s"),
> +			warning(_("gpg.ssh.defaultKeyCommand succeeded but returned no keys: %s %s"),
>   				key_stderr.buf, key_stdout.buf);
>   		}
>   

Looks OK.

> diff --git a/ref-filter.c b/ref-filter.c
> index 282cdad103..08a3f839c9 100644
> --- a/ref-filter.c
> +++ b/ref-filter.c
> @@ -1037,7 +1037,7 @@ int verify_ref_format(struct ref_format *format)
>   		     format->quote_style == QUOTE_TCL) &&
>   		     used_atom[at].atom_type == ATOM_RAW &&
>   		     used_atom[at].u.raw_data.option == RAW_BARE)
> -			die(_("--format=%.*s cannot be used with"
> +			die(_("--format=%.*s cannot be used with "
>   			      "--python, --shell, --tcl"), (int)(ep - sp - 2), sp + 2);
>   		cp = ep + 1;
>   
> 

Why not using \n?

-- 
An old man doll... just what I always wanted! - Clara