From: David Turner <david.turner@twosigma.com>
Date: Wed, 16 Nov 2016 00:07:34 GMT
Subject: RE: [PATCH 09/16] update submodules: add scheduling to update submodules
Message-ID: <7d6c85faf2f94a65947c65bad350532a@exmbdft7.ad.twosigma.com>
In-Reply-To: <20161116000236.GF66382@google.com>

> -----Original Message-----
> From: Brandon Williams [mailto:bmwill@google.com]
> > +struct scheduled_submodules_update_type {
> > +	const char *path;
> > +	const struct object_id *oid;
> > +	/*
> > +	 * Do we need to perform a complete checkout or just incremental
> > +	 * update?
> > +	 */
> > +	unsigned is_new:1;
> > +} *scheduled_submodules;
> > +#define SCHEDULED_SUBMODULES_INIT {NULL, NULL}
> 
> I may not know enough about these types of initializors but that Init
> macro only has 2 entries while there are three entries in the struct
> itself.

In fact, only the first NULL is necessary; unspecified initializer entries in C default to zero.