From: Derrick Stolee <stolee@gmail.com>
Date: Fri, 12 Dec 2025 13:57:11 GMT
Subject: Re: [PATCH v2 3/5] scalar: remove stale config values
Message-ID: <7d347708-2c47-4847-8e29-56e03c6a6a13@gmail.com>
In-Reply-To: <ciegbs72xbepxawuf42pne7eu354ntbok5e3p6jxcuyddvaea2@6ykt3iej32xt>

On 12/1/2025 12:46 PM, Matthew Hughes wrote:
> On Mon, Dec 01, 2025 at 04:50:45PM +0000, Derrick Stolee via GitGitGadget wrote:
>> * core.preloadIndex: This value is true by default, now. Removing this
>>   causes some changes required to the tests that checked this config
>>   value. Use gui.gcwarning=false instead.
> 
> I was going to ask about if we could also rely on the default value of
> index.threads like we do here, but then went and did some reading and realised
> some config values, like index.recordOffsetTable, have their value set
> according to whether index.threads was explicitly set, so I guess there's an
> implicit reliance on that behaviour that we want to keep?

Thanks for identifying this subtle behavior. I will mention it explicitly so
any future change that removes that behavior could also lead to a removal of
this explicit setting.

Thanks,
-Stolee