From: Jeff Hostetler <git@jeffhostetler.com>
Date: Fri, 27 Jul 2018 12:45:11 GMT
Subject: Re: [PATCH v1 03/25] structured-logging: add structured logging framework
Message-ID: <7d027531-71f2-0a64-a5a2-4c477dd7133b@jeffhostetler.com>
In-Reply-To: <20180726090921.32232-1-szeder.dev@gmail.com>



On 7/26/2018 5:09 AM, SZEDER Gábor wrote:
> 
>> +void slog_set_command_name(const char *command_name)
>> +{
>> +	/*
>> +	 * Capture the command name even if logging is not enabled
>> +	 * because we don't know if the config has been loaded yet by
>> +	 * the cmd_<command>() and/or it may be too early to force a
>> +	 * lazy load.
>> +	 */
>> +	if (my__command_name)
>> +		free(my__command_name);
>> +	my__command_name = xstrdup(command_name);
>> +}
>> +
>> +void slog_set_sub_command_name(const char *sub_command_name)
>> +{
>> +	/*
>> +	 * Capture the sub-command name even if logging is not enabled
>> +	 * because we don't know if the config has been loaded yet by
>> +	 * the cmd_<command>() and/or it may be too early to force a
>> +	 * lazy load.
>> +	 */
>> +	if (my__sub_command_name)
>> +		free(my__sub_command_name);
> 
> Please drop the condition in these two functions; free() handles NULL
> arguments just fine.

sure.

> 
> (Sidenote: what's the deal with these 'my__' prefixes anyway?)
> 

simply a way to identify file-scope variables and distinguish
them from local variables.

Jeff