From: Derrick Stolee <derrickstolee@github.com>
Date: Fri, 19 Aug 2022 12:53:55 GMT
Subject: Re: [PATCH v3 0/3] Allow --ancestry-path to take an argument
Message-ID: <7b7918f8-d997-89e8-2ba0-7bb31beb9335@github.com>
In-Reply-To: <pull.1303.v3.git.1660883290.gitgitgadget@gmail.com>

On 8/19/2022 12:28 AM, Elijah Newren via GitGitGadget wrote:
> Changes since v2:
> 
>  * Incorporated Stolee's suggested patch as a preliminary cleanup of t6019.
>    Slightly modified his patch by:
>    * fixing the "repetitive" typo pointed out by Eric
>    * removed the unnecessary "return 1" pointed out by Ævar
>    * switched "rev-list" to "log" since we are using --format anyway, in
>      order to remove the need to call "sed" afterward

Thanks! I appreciate you fixing all of my mistakes and
incorporating all of the existing feedback. It also looks
nicer as your patch 2 than as a third on top.

This version looks good to me.

-Stolee