From: Phillip Wood <phillip.wood123@gmail.com>
Date: Fri, 24 Oct 2025 13:36:28 GMT
Subject: Re: [PATCH v4 3/3] replay: add replay.refAction config option
Message-ID: <7a3161d1-4e30-4156-876d-7eede4b06705@gmail.com>
In-Reply-To: <a4cd31ad-7086-4d05-ba00-db65ec24b45a@gmail.com>

On 24/10/2025 14:28, Phillip Wood wrote:
> On 22/10/2025 19:50, Siddharth Asthana wrote:
> 
>> +    git replay --onto main topic1..topic2 >output &&
>> +    test_line_count = 1 output &&
>> +    grep "^update refs/heads/topic2 " output &&
> 
> Rather than test_line_count and grep it would be better to use test_cmp 
> here.

Oh, I've just realized we don't know the value of the ref so 
test_line_count() plus test_grep() (not grep) makes sense.

Thanks

Phillip